Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tearsheet): Slug to aiLabel #6169

Conversation

sangeethababu9223
Copy link
Member

@sangeethababu9223 sangeethababu9223 commented Oct 7, 2024

Closes #6096

Rename the prop slug to aiLabel.

What did you change?

  • Added Prop aiLabel
  • Deprecated slug prop
  • Updated the style with aiLabel classes as per the Core carbon standard

How did you test and verify your work?

Storybook

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 099c149
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/6717299e4376c60008d8bc8f
😎 Deploy Preview https://deploy-preview-6169--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sangeethababu9223 sangeethababu9223 changed the title Feat(Tearsheet): Slug to aiLabel feat(Tearsheet): Slug to aiLabel Oct 7, 2024
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review October 9, 2024 13:17
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner October 9, 2024 13:18
@sangeethababu9223 sangeethababu9223 requested review from elycheea and matthewgallo and removed request for a team October 9, 2024 13:18
Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for ibm-products-web-components ready!

Name Link
🔨 Latest commit 099c149
🔍 Latest deploy log https://app.netlify.com/sites/ibm-products-web-components/deploys/6717299eb2a0730008dde397
😎 Deploy Preview https://deploy-preview-6169--ibm-products-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos. “Scenario” and “accountability” were spelled slightly wrong but I think I caught them all. :)

cspell.json Outdated Show resolved Hide resolved
cspell.json Outdated Show resolved Hide resolved
@sangeethababu9223
Copy link
Member Author

Thanks @elycheea!
The changes are updated now.

elycheea
elycheea previously approved these changes Oct 18, 2024
Copy link
Contributor

@elycheea elycheea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (dc10d71) to head (98c85ed).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6169      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.02%     
==========================================
  Files         395      395              
  Lines       12794    12795       +1     
  Branches     4214     4215       +1     
==========================================
- Hits        10067    10066       -1     
- Misses       2727     2729       +2     
Components Coverage Δ
ibm-products ∅ <ø> (∅)
ibm-products-web-components ∅ <ø> (∅)

elycheea
elycheea previously approved these changes Oct 21, 2024
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@anamikaanu96 anamikaanu96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangeethababu9223 sangeethababu9223 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into carbon-design-system:main with commit 5c0f2ad Oct 22, 2024
30 checks passed
@sangeethababu9223 sangeethababu9223 deleted the feat/tearsheet-slug-to-ailabel branch October 22, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tearsheet: slug --> aiLabel renaming
4 participants